Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/5905 )
Change subject: KUDU-1865 (part 1): reduce some cross-thread allocations ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5905/7//COMMIT_MSG Commit Message: PS7: I also replaced std::function with boost::function in PS7 and ran synthetic tests ("master-test --gtest_filter='*ConcurrentGetT ableSchemaTest.Rpc*'" and "table_locations-itest --gtest_filter='*.GetTableLocationsBenchmark") on CentOS 7.5 machine with gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28). From the results below it's clear that the improvement is minuscule (under 1%). KUDU-1865 with boost::function instead of std::function; CentOS 7.5, RELEASE configuration built with gcc (GCC) 4.8.5 Without patch: GetTableLocations PRC: 29902.1 req/sec GetTableSchema RPC : 207100.0 req/sec With patch: GetTableLocations PRC: 30202.9 req/sec GetTableSchema RPC : 207674.0 req/sec As for rpc-bench, the improvements are tiny as well: Without patch: Mode: Sync Client threads: 16 Worker threads: 1 Server reactors: 4 Encryption: 0 ---------------------------------- Reqs/sec: 155254 User CPU per req: 31.7217us Sys CPU per req: 51.3626us Ctx Sw. per req: 3.46345 With patch: Mode: Sync Client threads: 16 Worker threads: 1 Server reactors: 4 Encryption: 0 ---------------------------------- Reqs/sec: 155015 User CPU per req: 32.9851us Sys CPU per req: 51.1958us Ctx Sw. per req: 3.48085 -- To view, visit http://gerrit.cloudera.org:8080/5905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d4d5f14fb302196b1797c712b21cfce81f157c1 Gerrit-Change-Number: 5905 Gerrit-PatchSet: 7 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 26 May 2020 23:01:41 +0000 Gerrit-HasComments: Yes
