Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16021 )
Change subject: [consensus] small cleanup on Peer::SignalRequest() ...................................................................... Patch Set 2: > You mentioned this to me on Slack: > "i also ran several micro-benches, they either showed 4-5% > improvement or at least no downside" > > It'd be nice to incorporate this in the commit message, or even > better, add a small benchmark tracking the spinlock contention time > in a low-heartbeat interval, write-heavy workload or somesuch. Yeah, I'm working on the test. Thank you for the review! -- To view, visit http://gerrit.cloudera.org:8080/16021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I899aec0964bc404e6df3742bd48d0d049e52d900 Gerrit-Change-Number: 16021 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 04 Jun 2020 01:40:20 +0000 Gerrit-HasComments: No
