Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16064 )
Change subject: [util] add BlockingQueueTest.MultiThreadPerf test scenario ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/16064/1/src/kudu/util/blocking_queue-test.cc File src/kudu/util/blocking_queue-test.cc: http://gerrit.cloudera.org:8080/#/c/16064/1/src/kudu/util/blocking_queue-test.cc@463 PS1, Line 463: LOG(INFO) << Substitute( nit: any reason to not log about the non-blocking Put throughput too? http://gerrit.cloudera.org:8080/#/c/16064/1/src/kudu/util/blocking_queue-test.cc@481 PS1, Line 481: MultiThreadPerfTest().Run(); nit: just curious, why bother encapsulating the run like this instead of writing Run() into this test method directly? -- To view, visit http://gerrit.cloudera.org:8080/16064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If52e4e15d3c72ad3479334f0f3fa8bb10b8c50c6 Gerrit-Change-Number: 16064 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 11 Jun 2020 12:53:51 +0000 Gerrit-HasComments: Yes
