Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16067
Change subject: WIP: [java] Add Java client metrics ...................................................................... WIP: [java] Add Java client metrics This patch adds the basic tools for instrumenting the Java Kudu client with metrics. The primary purpose for this patch is greater visibility and validation in tests. However, it leverages micrometer for the metrics to allow for exanded usage and use cases in the future (e.g JMX publishing, diagnostic logging, etc). In this patch I also add some counter metrics for RPC requests, retries, and responses. I leverage these metrics in TestScanToken to validate the current behavior of ScanToken generation and use. A follow on patch will use these metrics more to validate improvments to the ScanToken. I did not use or enhance the existing Statistics.java implimentation because it didn’t appear to be flexible and powerful enough for general purpose metrics without a lot of work (effectively writing something like micrometer). Outside of the additional work, Statistics.java is public API which makes it more difficult to change. Change-Id: I5c63835dd717c2c1e1dca06ed5dea3c2cadcd018 --- M java/gradle/dependencies.gradle M java/kudu-client/build.gradle M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java A java/kudu-client/src/main/java/org/apache/kudu/client/KuduMetrics.java M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java 6 files changed, 239 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/16067/1 -- To view, visit http://gerrit.cloudera.org:8080/16067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5c63835dd717c2c1e1dca06ed5dea3c2cadcd018 Gerrit-Change-Number: 16067 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]>
