Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16097 )
Change subject: [consensus] remove redundant instruction ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16097/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/16097/1/src/kudu/consensus/raft_consensus.cc@627 PS1, Line 627: ServiceUnavailable > Not this change but this error code is unusual when it's already in same st Yeah, another option would be simply returning Status::OK(). I'm not sure it's safe to change it right away without a risk to break corresponding tests: probably, this deserves to be in a separate patch, if changing this. -- To view, visit http://gerrit.cloudera.org:8080/16097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bbd40d89bcb39581dba15699bbfc9ed4036b11e Gerrit-Change-Number: 16097 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 19 Jun 2020 22:28:26 +0000 Gerrit-HasComments: Yes
