Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16043 )
Change subject: KUDU-2612 p1: add initial transaction status storage ...................................................................... Patch Set 9: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/16043/7/src/kudu/transactions/txn_status_tablet.cc File src/kudu/transactions/txn_status_tablet.cc: http://gerrit.cloudera.org:8080/#/c/16043/7/src/kudu/transactions/txn_status_tablet.cc@81 PS7, Line 81: static KuduOnceLambda col_idx_initializer; > > What's the benefit of using KuduOnceLambda over initializing these in a c Makes sense, thanks for the clarification. Do you think it's worth calling the KuduOnceLambda in the constructor instead to save the extra function calls? It might be premature optimization though, and also the compiler would probably optimize it out anyway (haven't checked). http://gerrit.cloudera.org:8080/#/c/16043/7/src/kudu/transactions/txn_status_tablet.cc@251 PS7, Line 251: if (PREDICT_FALSE(!prev_txn_id || *prev_txn_id != txn_id)) { > Yeah, the scan spec is ordered and only includes TRANSACTION and PARTICIPAN ah right, for some reason I thought that InList could include other types in the future. -- To view, visit http://gerrit.cloudera.org:8080/16043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94ddbd37c65932120835d6e138307f819935173c Gerrit-Change-Number: 16043 Gerrit-PatchSet: 9 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 23 Jun 2020 22:00:02 +0000 Gerrit-HasComments: Yes
