Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16031 )
Change subject: KUDU-1802: Avoid calls to master when using scan tokens ...................................................................... Patch Set 14: (10 comments) http://gerrit.cloudera.org:8080/#/c/16031/14/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/16031/14/src/kudu/client/client.h@2661 PS14, Line 2661: include_table_metadata include_tablet_metadata ? or maybe just replace with include_metadata for both methods? http://gerrit.cloudera.org:8080/#/c/16031/14/src/kudu/client/client.proto File src/kudu/client/client.proto: http://gerrit.cloudera.org:8080/#/c/16031/14/src/kudu/client/client.proto@44 PS14, Line 44: message ServerMetadataPB { : optional bytes uuid = 1; : : repeated HostPortPB rpc_addresses = 2; : : optional string location = 3; : } nit: add a doc for this message? Also, maybe it's worth documenting what 'location' means? http://gerrit.cloudera.org:8080/#/c/16031/14/src/kudu/client/client.proto@103 PS14, Line 103: optional TableMetadataPB table_metadata = 21; add [(kudu.REDACT) = true]? http://gerrit.cloudera.org:8080/#/c/16031/14/src/kudu/client/client.proto@107 PS14, Line 107: optional TabletMetadataPB tablet_metadata = 22; ditto http://gerrit.cloudera.org:8080/#/c/16031/14/src/kudu/client/meta_cache.h File src/kudu/client/meta_cache.h: http://gerrit.cloudera.org:8080/#/c/16031/14/src/kudu/client/meta_cache.h@341 PS14, Line 341: const MonoTime& expiration_time() { add 'const' specifier? http://gerrit.cloudera.org:8080/#/c/16031/14/src/kudu/client/scan_token-internal.cc File src/kudu/client/scan_token-internal.cc: http://gerrit.cloudera.org:8080/#/c/16031/14/src/kudu/client/scan_token-internal.cc@158 PS14, Line 158: entry Does it make sense to check for the staleness of an entry and populate the location information from the token, not from the cache in case if a stale entry is found? This also prompts a question: do we need to put TTL of the the location info into scan tokens? http://gerrit.cloudera.org:8080/#/c/16031/14/src/kudu/client/scan_token-internal.cc@206 PS14, Line 206: & no need to have reference for int, I think. http://gerrit.cloudera.org:8080/#/c/16031/14/src/kudu/client/scan_token-internal.cc@210 PS14, Line 210: & style int: stick '&' to the type http://gerrit.cloudera.org:8080/#/c/16031/14/src/kudu/client/scan_token-internal.cc@210 PS14, Line 210: const ColumnSchemaPB &column nit: replace with const auto& column ? http://gerrit.cloudera.org:8080/#/c/16031/14/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/16031/14/src/kudu/client/scan_token-test.cc@785 PS14, Line 785: int nit here and below: auto otherwise I expect compiler would warn about narrowing from 'uint64_t' to 'int' and signed/unsigned? -- To view, visit http://gerrit.cloudera.org:8080/16031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c1b8392de37dd5e8b7bd8b78a21603ff8b1d1b Gerrit-Change-Number: 16031 Gerrit-PatchSet: 14 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 24 Jun 2020 23:03:32 +0000 Gerrit-HasComments: Yes
