Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )
Change subject: KUDU-3090 Add ownership privileges ...................................................................... Patch Set 4: (5 comments) Took a brief first look. http://gerrit.cloudera.org:8080/#/c/16072/4//COMMIT_MSG Commit Message: PS4: This should be further split into two parts, because it attempts to do two distinct things: - add a means to change owners, including the privileges required to do so - have the Ranger subprocess check for ownership privileges http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/master/catalog_manager.cc@2954 PS4, Line 2954: unordered_set<TableOwnerPair, TableOwnerPairHash> Why can't you use an unordered_map? http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/ranger/ranger_client-test.cc File src/kudu/ranger/ranger_client-test.cc: http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/ranger/ranger_client-test.cc@247 PS4, Line 247: "notjdoe"); Shouldn't these be booleans? http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/security/simple_acl.h File src/kudu/security/simple_acl.h: http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/security/simple_acl.h@27 PS4, Line 27: TableOwnerPair nit: TableOwnerPair makes this sound like it should be a string, string pair. Consider TableAndIsOwner or somesuch http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/security/simple_acl.h@29 PS4, Line 29: struct TableOwnerPairHash { : int operator()(const TableOwnerPair& table_owner_pair) const { : return std::hash<std::string>{}(table_owner_pair.first); : } : }; The fact that this doesn't take into account 'owner' seems wrong. -- To view, visit http://gerrit.cloudera.org:8080/16072 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109 Gerrit-Change-Number: 16072 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 25 Jun 2020 17:05:40 +0000 Gerrit-HasComments: Yes
