Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16031 )
Change subject: KUDU-1802: Avoid calls to master when using scan tokens ...................................................................... Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/16031/18/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java: http://gerrit.cloudera.org:8080/#/c/16031/18/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java@500 PS18, Line 500: // Even if we add the table metadata, we should also set the old table id : // and name for backward compatibility. : proto.setTableId(table.getTableId()); : proto.setTableName(table.getName()); > Good catch! Did you find that by testing against real some system? Do you I didn't see any specific issue yet. I wen't back and forth with it on this patch, but decided to add it just in case. I am working on testing with Impala right now. -- To view, visit http://gerrit.cloudera.org:8080/16031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c1b8392de37dd5e8b7bd8b78a21603ff8b1d1b Gerrit-Change-Number: 16031 Gerrit-PatchSet: 18 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 25 Jun 2020 17:32:46 +0000 Gerrit-HasComments: Yes
