Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/16110 )
Change subject: [test_util] multiple bind address for WaitFor{Tcp,Udp}Bind()
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16110/2/src/kudu/util/test_util.h
File src/kudu/util/test_util.h:
http://gerrit.cloudera.org:8080/#/c/16110/2/src/kudu/util/test_util.h@148
PS2, Line 148: (if no address is not provided
nit: "if no address is provided" or "if an address is not provided"
http://gerrit.cloudera.org:8080/#/c/16110/2/src/kudu/util/test_util.cc
File src/kudu/util/test_util.cc:
http://gerrit.cloudera.org:8080/#/c/16110/2/src/kudu/util/test_util.cc@473
PS2, Line 473: port_determined = true;
: break;
nit: could return here and forego tracking port_determined
--
To view, visit http://gerrit.cloudera.org:8080/16110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacda85624cb31995adc5910302468d80d5177237
Gerrit-Change-Number: 16110
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 25 Jun 2020 17:40:04 +0000
Gerrit-HasComments: Yes
