Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16147 )
Change subject: Use protobuf arenas for CommitMsgs ...................................................................... Patch Set 2: (3 comments) Overall looks good to me, but it seems many tests need to be updated: t hey fail with errors like F0707 23:05:28.555228 1482 write_op.cc:410] Check failed: op->result->GetArena() == result->GetArena() (0x7f705ca0acf0 vs. 0) http://gerrit.cloudera.org:8080/#/c/16147/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16147/2//COMMIT_MSG@89 PS2, Line 89: Summary: : * 9.6% throughput increase : * 39% reduction in tserver cycles Nice improvement, indeed! http://gerrit.cloudera.org:8080/#/c/16147/2/src/kudu/consensus/log.h File src/kudu/consensus/log.h: http://gerrit.cloudera.org:8080/#/c/16147/2/src/kudu/consensus/log.h@591 PS2, Line 591: replicate_op_ids_.back(); What if replicate_op_ids_ is empty? Maybe, add a CHECK() on this pre-condition? http://gerrit.cloudera.org:8080/#/c/16147/2/src/kudu/tablet/ops/write_op.cc File src/kudu/tablet/ops/write_op.cc: http://gerrit.cloudera.org:8080/#/c/16147/2/src/kudu/tablet/ops/write_op.cc@243 PS2, Line 243: nit: trailing space -- To view, visit http://gerrit.cloudera.org:8080/16147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78698d4cb4944bddd8dabd6cbbf1e3a064056199 Gerrit-Change-Number: 16147 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 08 Jul 2020 05:54:39 +0000 Gerrit-HasComments: Yes
