Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16154 )
Change subject: [master] set RPC queue length to 100 by default ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16154/1/src/kudu/master/master_runner.cc File src/kudu/master/master_runner.cc: http://gerrit.cloudera.org:8080/#/c/16154/1/src/kudu/master/master_runner.cc@63 PS1, Line 63: constexpr > nit:static constexpr. Or it doesn't matter because address is never taken? Whoops, already pushed this change after getting +2 from Grant :) I guess so, and it doesn't make much difference from the other side because this method is not in a hot path anyways. -- To view, visit http://gerrit.cloudera.org:8080/16154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia90bc157d8a0d52b6d1320cf67bc533a51faf101 Gerrit-Change-Number: 16154 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 09 Jul 2020 15:55:58 +0000 Gerrit-HasComments: Yes
