Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16162 )
Change subject: KUDU-636. Use Arena for EncodedKeys ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16162/2/src/kudu/common/encoded_key.cc File src/kudu/common/encoded_key.cc: http://gerrit.cloudera.org:8080/#/c/16162/2/src/kudu/common/encoded_key.cc@56 PS2, Line 56: Status EncodedKey::DecodeEncodedString(const Schema& schema, : Arena* arena, > I was trying to use clang-format-diff with the Google style, which ends up Thank you for addressing that! -- To view, visit http://gerrit.cloudera.org:8080/16162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib46d0e2c31e03a7f319ceb0bf742e08ff74d7683 Gerrit-Change-Number: 16162 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 10 Jul 2020 16:50:10 +0000 Gerrit-HasComments: Yes
