Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16116 )
Change subject: KUDU-2612 p3: tserver mechanism to create txn status tablets ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/16116/3/src/kudu/integration-tests/ts_tablet_manager-itest.cc File src/kudu/integration-tests/ts_tablet_manager-itest.cc: http://gerrit.cloudera.org:8080/#/c/16116/3/src/kudu/integration-tests/ts_tablet_manager-itest.cc@998 PS3, Line 998: > nit: maybe, remove this extra line? Done http://gerrit.cloudera.org:8080/#/c/16116/3/src/kudu/integration-tests/ts_tablet_manager-itest.cc@1027 PS3, Line 1027: const char* > nit: might be 'static const char* const' or even constexpr Done http://gerrit.cloudera.org:8080/#/c/16116/3/src/kudu/integration-tests/ts_tablet_manager-itest.cc@1069 PS3, Line 1069: const ParticipantIdsByTxnId > nit: why not 'const ParticipantIdsByTxnId&' ? Done http://gerrit.cloudera.org:8080/#/c/16116/3/src/kudu/transactions/txn_status_tablet.h File src/kudu/transactions/txn_status_tablet.h: http://gerrit.cloudera.org:8080/#/c/16116/3/src/kudu/transactions/txn_status_tablet.h@85 PS3, Line 85: const char* > nit: might be even 'const char* const' or 'constexpr const char* const' Done -- To view, visit http://gerrit.cloudera.org:8080/16116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib429f055e12944fa930f3e95ec4f2504466d3d02 Gerrit-Change-Number: 16116 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 13 Jul 2020 18:56:20 +0000 Gerrit-HasComments: Yes
