Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16193 )
Change subject: KUDU-2612 p5: RPC endpoints for txn status management ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/16193/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc File src/kudu/integration-tests/ts_tablet_manager-itest.cc: http://gerrit.cloudera.org:8080/#/c/16193/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc@1201 PS6, Line 1201: const vector<CoordinatorOpPB::CoordinatorOpType> kOpSe > nit: add 'const' ? Done http://gerrit.cloudera.org:8080/#/c/16193/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc@1208 PS6, Line 1208: use > nit: use Done http://gerrit.cloudera.org:8080/#/c/16193/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc@1230 PS6, Line 1230: if (expect_success) { > nit: would it suffice to have SCOPED_TRACE(SecureDebugString(resp)) outside Done -- To view, visit http://gerrit.cloudera.org:8080/16193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id846160724b334d2c52eb9a1bae0ffd19536bcc9 Gerrit-Change-Number: 16193 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 25 Jul 2020 05:51:45 +0000 Gerrit-HasComments: Yes
