Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16265 )
Change subject: [tests] fix potential memory leak ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16265/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/16265/1/src/kudu/tools/kudu-tool-test.cc@913 PS1, Line 913: STLDeleteValues(&ts_map_); > I intentionally didn't put that into CreateTabletServerMap(), and the reaso Thank you for explaining. Good point about how it would leave this with convoluted memory-tracking semantics. I agree a smart pointer would be a better fit but +2 to deferring that in favor of this for now. -- To view, visit http://gerrit.cloudera.org:8080/16265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2e6132eb4cb027055b1523ff4e89d206d7eb973 Gerrit-Change-Number: 16265 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 31 Jul 2020 18:40:55 +0000 Gerrit-HasComments: Yes
