Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16194 )
Change subject: KUDU-2612 p6: add coordination calls to system client ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/16194/6/src/kudu/integration-tests/auth_token_expire-itest.cc File src/kudu/integration-tests/auth_token_expire-itest.cc: http://gerrit.cloudera.org:8080/#/c/16194/6/src/kudu/integration-tests/auth_token_expire-itest.cc@470 PS6, Line 470: ASSERT_OK(txn_client->OpenTxnStatusTable()); > Wouldn't the connection already have been reset by the cluster restart? The How to make sure the expired token is used to begin a transaction? If the connection kept open, authn token will not be verified, so it's doesn't matter whether it has expired or not if it's not used to authenticate a user. I guess the sleep interval should depend not only on the authn token validity interval, but also on the timeout for the inactive connections (controlled by rpc_default_keepalive_time_ms). http://gerrit.cloudera.org:8080/#/c/16194/6/src/kudu/transactions/txn_system_client.cc File src/kudu/transactions/txn_system_client.cc: http://gerrit.cloudera.org:8080/#/c/16194/6/src/kudu/transactions/txn_system_client.cc@177 PS6, Line 177: First, take ownership of the context. > That runs the risk of having 'ctx' going out of scope and being destructed I meant replacing unique_ptr<TxnStatusTabletContext> ctx(ctx_raw); with something like unique_ptr<TxnStatusTabletContext> context(ctx.release()); and removing ignore_result(ctx.release()) Why wouldn't it work? -- To view, visit http://gerrit.cloudera.org:8080/16194 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4126cb3dcf379b397f84578c2265dca3ece3d98c Gerrit-Change-Number: 16194 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sun, 02 Aug 2020 17:01:44 +0000 Gerrit-HasComments: Yes
