Kevin McCarthy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16276 )
Change subject: [KUDU-3177] Added kudu.snapshotTimestampMicros to kudu spark readOptions as optional property ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16276/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala: http://gerrit.cloudera.org:8080/#/c/16276/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala@71 PS1, Line 71: if (options.scanLocality == ReplicaSelection.CLOSEST_REPLICA) { > I think you could set READ_AT_SNAPSHOT if `options.scanLocality == ReplicaS Done http://gerrit.cloudera.org:8080/#/c/16276/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala: http://gerrit.cloudera.org:8080/#/c/16276/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala@773 PS1, Line 773: val timestamp = System.currentTimeMillis() * 1000 > You can use the HybridTimeUtil class to convert as needed: Done -- To view, visit http://gerrit.cloudera.org:8080/16276 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00862c0e174a964efc6cab0b8141b1ac5a1bebc0 Gerrit-Change-Number: 16276 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin McCarthy <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kevin McCarthy <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 03 Aug 2020 21:47:45 +0000 Gerrit-HasComments: Yes
