Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16293 )
Change subject: [scripts] fix y-axis label for benchmarks.sh ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16293/2/src/kudu/scripts/benchmarks.sh File src/kudu/scripts/benchmarks.sh: http://gerrit.cloudera.org:8080/#/c/16293/2/src/kudu/scripts/benchmarks.sh@664 PS2, Line 664: row/sec, row/cpusec > Why are there two units here? The generated plot contains two data series: one is throughput (rows per wall-second), another is total CPU usage of both the client and server (rows per cpu-second). * https://gerrit.cloudera.org/#/c/16293/2/src/kudu/scripts/benchmarks.sh@477 * https://gerrit.cloudera.org/#/c/16293/2/src/kudu/scripts/benchmarks.sh@479 I'm not sure it makes sense to keep those at the same plot because the difference is in the order of a multiple of CPU cores in the system. I'll separate those, thanks. -- To view, visit http://gerrit.cloudera.org:8080/16293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e5fb5efa742f2321ad8d52a794311defff620e9 Gerrit-Change-Number: 16293 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 06 Aug 2020 19:39:57 +0000 Gerrit-HasComments: Yes
