Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16304 )
Change subject: KUDU-2612 p8: replay participant ops on bootstrap ...................................................................... Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/16304/1/src/kudu/integration-tests/txn_participant-itest.cc File src/kudu/integration-tests/txn_participant-itest.cc: http://gerrit.cloudera.org:8080/#/c/16304/1/src/kudu/integration-tests/txn_participant-itest.cc@193 PS1, Line 193: TEST_F(TxnParticipantITest, TestCopyParticipantOps) { Do you mind adding a short doc blurb to summarize the essence of this test scenario? http://gerrit.cloudera.org:8080/#/c/16304/1/src/kudu/integration-tests/txn_participant-itest.cc@196 PS1, Line 196: const nit: constexpr ? http://gerrit.cloudera.org:8080/#/c/16304/1/src/kudu/integration-tests/txn_participant-itest.cc@201 PS1, Line 201: MonoDelta::FromSeconds(10) nit: separate this into a constant and use here and at line 230 ? http://gerrit.cloudera.org:8080/#/c/16304/1/src/kudu/integration-tests/txn_participant-itest.cc@207 PS1, Line 207: statuses What is the significance of collecting these statuses? I could not see that the test scenario uses it later on. http://gerrit.cloudera.org:8080/#/c/16304/1/src/kudu/integration-tests/txn_participant-itest.cc@225 PS1, Line 225: 3 nit: maybe, replace with cluter_->num_tablet_servers() http://gerrit.cloudera.org:8080/#/c/16304/1/src/kudu/tablet/ops/participant_op.h File src/kudu/tablet/ops/participant_op.h: http://gerrit.cloudera.org:8080/#/c/16304/1/src/kudu/tablet/ops/participant_op.h@61 PS1, Line 61: ValidateOp() It would nit nice to add a short doc blurb explaining the essence what kind of validation is performed here. http://gerrit.cloudera.org:8080/#/c/16304/1/src/kudu/tablet/ops/participant_op.h@61 PS1, Line 61: ValidateOp Could ValidateOp() be a private method? http://gerrit.cloudera.org:8080/#/c/16304/1/src/kudu/tablet/ops/participant_op.cc File src/kudu/tablet/ops/participant_op.cc: http://gerrit.cloudera.org:8080/#/c/16304/1/src/kudu/tablet/ops/participant_op.cc@124 PS1, Line 124: txn->BeginTransaction() nit here and elsewhere with successful cases: just return from the method? Or the idea is that there will be some extra-code in the future as the note above explains? http://gerrit.cloudera.org:8080/#/c/16304/1/src/kudu/tablet/txn_participant-test.cc File src/kudu/tablet/txn_participant-test.cc: http://gerrit.cloudera.org:8080/#/c/16304/1/src/kudu/tablet/txn_participant-test.cc@291 PS1, Line 291: const nit: constexpr ? http://gerrit.cloudera.org:8080/#/c/16304/1/src/kudu/tablet/txn_participant-test.cc@303 PS1, Line 303: nit: remove the extra line? -- To view, visit http://gerrit.cloudera.org:8080/16304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I199ed01c2244d16ed6fd7ded063e4c71f3c409ff Gerrit-Change-Number: 16304 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 08 Aug 2020 04:46:16 +0000 Gerrit-HasComments: Yes
