Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16319 )
Change subject: KUDU-3180: prioritize larger mem-stores in time-based flusing ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16319/1/src/kudu/tablet/tablet_replica_mm_ops.cc File src/kudu/tablet/tablet_replica_mm_ops.cc: http://gerrit.cloudera.org:8080/#/c/16319/1/src/kudu/tablet/tablet_replica_mm_ops.cc@120 PS1, Line 120: std::max(1.0, extra_mb) Clever! That said, I'm curious why we'd prefer this change over, for instance, lowering --flush_threshold_mb by 1. You mentioned on the ticket that lowering the threshold isn't viable because it conflicts with the block cache capacity. That said, does this change help your cluster much? -- To view, visit http://gerrit.cloudera.org:8080/16319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a826643709a4990e40b0a49f89f4ea34f14163b Gerrit-Change-Number: 16319 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 10 Aug 2020 22:29:32 +0000 Gerrit-HasComments: Yes
