Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16316 )
Change subject: [kserver] fix const-correctness for getter methods ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16316/1/src/kudu/kserver/kserver.h File src/kudu/kserver/kserver.h: http://gerrit.cloudera.org:8080/#/c/16316/1/src/kudu/kserver/kserver.h@65 PS1, Line 65: scoped_refptr<AtomicGauge<int32_t>> num_raft_leaders() { return num_raft_leaders_; } > The smart pointer gets passed around to different Raft instances to update Yup, exactly; for example it's updated here: https://github.com/apache/kudu/blob/0cc190f9b149ade571162fe43937ca7dcce8a116/src/kudu/consensus/raft_consensus.cc#L742 -- To view, visit http://gerrit.cloudera.org:8080/16316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id845e36ab99b3b9bd5c4ccb5eb6263a96acd5a0a Gerrit-Change-Number: 16316 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 10 Aug 2020 23:52:11 +0000 Gerrit-HasComments: Yes
