Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16332 )
Change subject: KUDU-1587 part 1: load meter for ThreadPool ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16332/3/src/kudu/util/threadpool.h File src/kudu/util/threadpool.h: http://gerrit.cloudera.org:8080/#/c/16332/3/src/kudu/util/threadpool.h@154 PS3, Line 154: scoped_refptr<QueueLoadMeter> load_meter; Once I started implementing the code that uses the newly introduced functionality, I realized it's better to make the load meter an internal class of ThreadPool and introduce a new method ThreadPool::IsQueueOverloaded(). I guess it doesn't change much of the functionality, but just a heads-up. -- To view, visit http://gerrit.cloudera.org:8080/16332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I640716dc32f193e68361ca623ee7b9271e661d8b Gerrit-Change-Number: 16332 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 14 Aug 2020 19:17:44 +0000 Gerrit-HasComments: Yes
