Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8717 )
Change subject: [util] operators for MonoDelta addition/subtraction ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8717/2/src/kudu/util/monotime.h File src/kudu/util/monotime.h: http://gerrit.cloudera.org:8080/#/c/8717/2/src/kudu/util/monotime.h@323 PS2, Line 323: MonoDelta KUDU_EXPORT operator-(const MonoDelta& lhs, const MonoDelta& rhs); > this looks like a clang-tidy bug and we should add // NOLINT(readability-re It seems current version of clang-tidy is no longer affected by such a bug. http://gerrit.cloudera.org:8080/#/c/8717/2/src/kudu/util/monotime.h@330 PS2, Line 330: MonoDelta KUDU_EXPORT operator+(const MonoDelta& lhs, const MonoDelta& rhs); > and here ditto -- To view, visit http://gerrit.cloudera.org:8080/8717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc1fe1e2dd3b47b6a0d9ef977749c7c27dbf168c Gerrit-Change-Number: 8717 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 14 Aug 2020 22:37:30 +0000 Gerrit-HasComments: Yes
