Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16298 )
Change subject: [docker] Generate all tags in a single build command ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16298/2/docker/docker-build.py File docker/docker-build.py: http://gerrit.cloudera.org:8080/#/c/16298/2/docker/docker-build.py@299 PS2, Line 299: tags.append(tags) Is append() correct here? Or do you want extend()? Also, is this a recursive append? If that's not intentional, can you change one of the 'tags' variable names? -- To view, visit http://gerrit.cloudera.org:8080/16298 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iccb0b2ec02940457487852f048d80a42a39e5fb4 Gerrit-Change-Number: 16298 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 25 Aug 2020 22:01:39 +0000 Gerrit-HasComments: Yes
