Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16354 )
Change subject: [build] Adjust JAVA_HOME candidates ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16354/1/build-support/java-home-candidates.txt File build-support/java-home-candidates.txt: http://gerrit.cloudera.org:8080/#/c/16354/1/build-support/java-home-candidates.txt@18 PS1, Line 18: in priority order. > What are the guiding principles here? It looks like it was newer to older, specific to generic. I didn't intent to change that in this patch. http://gerrit.cloudera.org:8080/#/c/16354/1/build-support/java-home-candidates.txt@51 PS1, Line 51: /Library/Java/Home > nit: maybe JAVA installation on my laptop is missing something, but in my c This came from the updated version of bigtop-detect-javahome which is the original inspiration for this file. I don't see a reason not to include it. https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/bigtop-utils/bigtop-detect-javahome -- To view, visit http://gerrit.cloudera.org:8080/16354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16 Gerrit-Change-Number: 16354 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 26 Aug 2020 13:55:09 +0000 Gerrit-HasComments: Yes
