Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16361 )
Change subject: [docker] Support building and pushing multi-arch images ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16361/1/docker/docker-build.py File docker/docker-build.py: http://gerrit.cloudera.org:8080/#/c/16361/1/docker/docker-build.py@316 PS1, Line 316: build_tags > Do we need to add per-platform tags? Or can we push images for multiple pla The common practice is not to add a separate image tag for the platform, but instead to use build manifests to include all of the supported platforms under the same tag. Then the correct image for your platform is automatically pulled. Alternatively you can override and use emulation by specifying --platform in your run commands. This is primarily what the buildx builder is doing for us. Building both images in parallel, generating the manifest, and pushing the images, manifests, and tags. -- To view, visit http://gerrit.cloudera.org:8080/16361 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f64e4b9591927f160cdf886507cb740578e20b5 Gerrit-Change-Number: 16361 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 26 Aug 2020 20:27:35 +0000 Gerrit-HasComments: Yes
