Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16358 )
Change subject: KUDU-2612 p9: anchor participant ops in WAL ...................................................................... Patch Set 5: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/16358/5/src/kudu/consensus/log_anchor_registry.cc File src/kudu/consensus/log_anchor_registry.cc: http://gerrit.cloudera.org:8080/#/c/16358/5/src/kudu/consensus/log_anchor_registry.cc@161 PS5, Line 161: if (PREDICT_FALSE(minimum_log_index_ == kInvalidOpIdIndex) || : log_index < minimum_log_index_ nit: if the first part of this OR condition is very unlikely to be evaluated to 'true', maybe switch the order here? if (log_index < minimum_log_index_ || REDICT_FALSE(minimum_log_index_ == kInvalidOpIdIndex)) { ... } http://gerrit.cloudera.org:8080/#/c/16358/3/src/kudu/tablet/txn_participant-test.cc File src/kudu/tablet/txn_participant-test.cc: http://gerrit.cloudera.org:8080/#/c/16358/3/src/kudu/tablet/txn_participant-test.cc@84 PS3, Line 84: > This reads correctly as is: we disable anything that might write to disk so OK, thanks for the clarification. -- To view, visit http://gerrit.cloudera.org:8080/16358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I936f0a345c4b6095f0d99b6dd244e3092ae3f9d7 Gerrit-Change-Number: 16358 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 01 Sep 2020 06:51:29 +0000 Gerrit-HasComments: Yes
