Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16388 )
Change subject: WIP - KUDU-3187: Enhance the HMS plugin to check if synchronization is enabled ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java File java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@201 PS1, Line 201: checkNoKuduProperties another comment on this is that checkNoKuduProperties will also call isKuduTable, which at this point is redundant. http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@201 PS1, Line 201: checkNoKuduProperties(newTable); checkNoKuduProperties does not check for KUDU_MASTER_ADDRS_KEY - is that intentional? http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@206 PS1, Line 206: kuduSyncEnabled Thinking about the execution path for non-Kudu tables, it will return faster if this check is performed before the previous one. http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@57 PS1, Line 57: import org.apache.kudu.test.junit.RetryRule; Remove this import since you've removed the annotation below? -- To view, visit http://gerrit.cloudera.org:8080/16388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3588d72af1bb499202b47fca50a08876e13ea37 Gerrit-Change-Number: 16388 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 01 Sep 2020 17:13:12 +0000 Gerrit-HasComments: Yes
