Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16420 to look at the new patch set (#6). Change subject: KUDU-2884: [hms] Improve master address matching ...................................................................... KUDU-2884: [hms] Improve master address matching This patch improves the master address matching in the `kudu hms fix` tool. Instead of expecting a literal match of the address strings, it expects the match to be functionally the same. This means that the addresses can be missing the port (using the default), duplicated, and re-ordered. The HMS will still consider them the same if they match the clusters masters functionally. Though the default port is considered when matching master addresses, it is not included in the automated hms tool tests given the tests use random ephemeral ports. Instead a test for MasterAddressesToSet and UnorderedHostPortSet equality was added. Change-Id: I00059ff1b5134f7e5d6ea8be4fdf0701aa56b0c7 --- M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action-test.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_common.h M src/kudu/tools/tool_action_hms.cc 5 files changed, 136 insertions(+), 34 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/16420/6 -- To view, visit http://gerrit.cloudera.org:8080/16420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I00059ff1b5134f7e5d6ea8be4fdf0701aa56b0c7 Gerrit-Change-Number: 16420 Gerrit-PatchSet: 6 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120)