Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16388 )
Change subject: KUDU-3187: Enhance the HMS plugin to check if synchronization is enabled ...................................................................... Patch Set 7: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/16388/7/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java File java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/16388/7/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@478 PS7, Line 478: // If the request is from the Kudu Master, we know HMS sync is enabled : // and can avoid another request. : if (isKuduMasterAction(event)) { : return true; I seem to recall tooling also setting this. Does that break any invariants, e.g. if we're running the fix tool while the Kudu master isn't yet HMS-ready? -- To view, visit http://gerrit.cloudera.org:8080/16388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3588d72af1bb499202b47fca50a08876e13ea37 Gerrit-Change-Number: 16388 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Sep 2020 18:24:04 +0000 Gerrit-HasComments: Yes
