Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16460 )
Change subject: test: fix file block manager tests following eaf1b6d ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/16460/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16460/3//COMMIT_MSG@12 PS3, Line 12: There was also a functional test adjustment Is it still so after this change? If so, is it make sense to have the behavior more uniform (if it's not too hard)? http://gerrit.cloudera.org:8080/#/c/16460/3/src/kudu/fs/fs_manager-test.cc File src/kudu/fs/fs_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/16460/3/src/kudu/fs/fs_manager-test.cc@463 PS3, Line 463: << s.ToString() nit: this wouldn't output much useful information if the assert triggers (would be just 'OK'). -- To view, visit http://gerrit.cloudera.org:8080/16460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b210869464c69d0ff024d030bd553d23b21352f Gerrit-Change-Number: 16460 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 16 Sep 2020 21:38:33 +0000 Gerrit-HasComments: Yes
