Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16461 )
Change subject: Fix assign-location.py on Python 3.8+ ...................................................................... Patch Set 1: (1 comment) I verified the updated script works for Python 2.7 on macOS HighSierra. http://gerrit.cloudera.org:8080/#/c/16461/1/src/kudu/scripts/assign-location.py File src/kudu/scripts/assign-location.py: http://gerrit.cloudera.org:8080/#/c/16461/1/src/kudu/scripts/assign-location.py@98 PS1, Line 98: # time.clock() is deprecated since Python 3.3 and removed in Python 3.8. > Would it be possible to try process_time() first, since that's what we expe As an option, maybe use time.mktime(time.localtime()) to be portable across python version? It's fine to have 1 second resolution in this context -- the code will work as needed. This works for Python2.7. Would this work for Python 3.8? -- To view, visit http://gerrit.cloudera.org:8080/16461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21f9f8bc519a7286d17a012404b074494461e571 Gerrit-Change-Number: 16461 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 16 Sep 2020 22:42:58 +0000 Gerrit-HasComments: Yes
