Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16458 )
Change subject: Fix Unix socket usage on macOS ...................................................................... Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16458/5/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: http://gerrit.cloudera.org:8080/#/c/16458/5/src/kudu/rpc/rpc-test.cc@117 PS5, Line 117: unlink(socket_path_.c_str()); > I am not sure. I think I prefer ulink given it the defacto way to handle so As an additional point for advocating for the change, I looked through tests and found that we primarily use Env::X() for filesystem operations instead of direct system calls. But I guess it's OK to use unlink() here since it's not critical in this context of a clean-up for a test scenario. So, feel free to ignore if my attempt to sell this change isn't appealing :) -- To view, visit http://gerrit.cloudera.org:8080/16458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I434e92e86fb87d1085c35b5d707d1238295192fb Gerrit-Change-Number: 16458 Gerrit-PatchSet: 6 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 21 Sep 2020 23:20:28 +0000 Gerrit-HasComments: Yes
