Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16493 )
Change subject: KUDU-3192: [client] Expose the cluster ID in the client KuduTable ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16493/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16493/2//COMMIT_MSG@9 PS2, Line 9: This patch adds a cluster ID field to the KuduTable object in the I'm surprised this field has to be associated with Kudu tables instead of entire Kudu clients, which get initialized with a single cluster via the master addresses. I understand that it will be a per table field in the HMS, but I'm not convinced that means it should be a public API for tables. -- To view, visit http://gerrit.cloudera.org:8080/16493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1f5a451aaa44834534d2387ee1c9aa9cf95dd37 Gerrit-Change-Number: 16493 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 23 Sep 2020 17:44:13 +0000 Gerrit-HasComments: Yes