Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16321 )
Change subject: [master] KUDU-2181 Raft ChangeConfig request to add a master ...................................................................... Patch Set 6: (19 comments) http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/catalog_manager.cc@1615 PS6, Line 1615: optional<const string&> user = rpc ? > error: no viable conversion from 'optional<typename boost::decay<const basi Done http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/catalog_manager.cc@1848 PS6, Line 1848: req.has_dimension_label() ? make_optional<string>(req.dimension_label()) : none; > error: no matching function for call to 'make_optional' [clang-diagnostic-e Done http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/catalog_manager.cc@2146 PS6, Line 2146: optional<const string&> user = rpc ? > error: no viable conversion from 'optional<typename boost::decay<const basi Done http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/catalog_manager.cc@2506 PS6, Line 2506: make_optional<string>(step.add_range_partition().dimension_label()) : none; > error: no matching function for call to 'make_optional' [clang-diagnostic-e Done http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/catalog_manager.cc@2581 PS6, Line 2581: optional<const string&> user = rpc ? > error: no viable conversion from 'optional<typename boost::decay<const basi Done http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/catalog_manager.cc@4822 PS6, Line 4822: make_optional<string>(old_info.pb.dimension_label()) : none; > error: no matching function for call to 'make_optional' [clang-diagnostic-e Done http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/dynamic_multi_master-test.cc@162 PS6, Line 162: } > Nit: Would it make sense to define a deadline instead and keep retrying unt Done http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/dynamic_multi_master-test.cc@177 PS6, Line 177: return std::make_pair(std::move(s), std::move(err_code)); > warning: std::move of the variable 'err_code' of the trivially-copyable typ Done http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/dynamic_multi_master-test.cc@263 PS6, Line 263: return std::make_pair(std::move(s), std::move(err_code)); > warning: std::move of the variable 'err_code' of the trivially-copyable typ Done http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/dynamic_multi_master-test.cc@266 PS6, Line 266: return RunLeaderMasterRPC(add_master).AndThen([&] { > Nit: AndThen is useful when we need to do something extra with the result o Done http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/dynamic_multi_master-test.cc@399 PS6, Line 399: } > The log_gc_duration histogram metric has a TotalCount() method that might b Done. Thanks! http://gerrit.cloudera.org:8080/#/c/16321/5/src/kudu/master/master.cc File src/kudu/master/master.cc: http://gerrit.cloudera.org:8080/#/c/16321/5/src/kudu/master/master.cc@424 PS5, Line 424: auto > Missed this? Indeed. Done. http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/master_service.cc@435 PS6, Line 435: make_optional<const string&>(rpc->remote_user().username())); > error: no viable conversion from 'optional<typename boost::decay<const basi Done http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/master_service.cc@474 PS6, Line 474: req, resp, make_optional<const string&>(rpc->remote_user().username())); > error: no viable conversion from 'optional<typename boost::decay<const basi Done http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/master_service.cc@514 PS6, Line 514: req, resp, make_optional<const string&>(rpc->remote_user().username())); > error: no viable conversion from 'optional<typename boost::decay<const basi Done http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/master_service.cc@528 PS6, Line 528: req, resp, make_optional<const string&>(rpc->remote_user().username())); > error: no viable conversion from 'optional<typename boost::decay<const basi Done http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/master_service.cc@541 PS6, Line 541: req, resp, make_optional<const string&>(rpc->remote_user().username())); > error: no viable conversion from 'optional<typename boost::decay<const basi Done http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/master_service.cc@563 PS6, Line 563: req, resp, make_optional<const string&>(rpc->remote_user().username())); > error: no viable conversion from 'optional<typename boost::decay<const basi Done http://gerrit.cloudera.org:8080/#/c/16321/6/src/kudu/master/master_service.cc@581 PS6, Line 581: req, resp, make_optional<const string&>(rpc->remote_user().username()), > error: no viable conversion from 'optional<typename boost::decay<const basi Done -- To view, visit http://gerrit.cloudera.org:8080/16321 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ac7e6e55220bcb01cad0fa386daaf656258088c Gerrit-Change-Number: 16321 Gerrit-PatchSet: 6 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 23 Sep 2020 22:38:27 +0000 Gerrit-HasComments: Yes
