Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16501 )
Change subject: KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient ...................................................................... Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/16501/1/src/kudu/integration-tests/txn_status_table-itest.cc File src/kudu/integration-tests/txn_status_table-itest.cc: http://gerrit.cloudera.org:8080/#/c/16501/1/src/kudu/integration-tests/txn_status_table-itest.cc@516 PS1, Line 516: : ASSERT_OK(txn_sys_client_->AbortTransaction(1, kUser)); : NO_FATALS(verify_state(TxnStatePB::ABORTED)); nit: just making sure this was intentional; maybe add a comment if it was http://gerrit.cloudera.org:8080/#/c/16501/1/src/kudu/integration-tests/txn_status_table-itest.cc@521 PS1, Line 521: nullptr nit: rather than allowing nullptrs in GetTransactionStatus(), maybe instead verify that nothing is set on error? http://gerrit.cloudera.org:8080/#/c/16501/1/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/16501/1/src/kudu/tserver/tablet_service.cc@1198 PS1, Line 1198: case CoordinatorOpPB::GET_TXN_STATUS: nit: may belong as a part of https://gerrit.cloudera.org/c/16495/ ? -- To view, visit http://gerrit.cloudera.org:8080/16501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7fac7158df307d03db6a48087e7c5a16269a3bc6 Gerrit-Change-Number: 16501 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 27 Sep 2020 19:59:28 +0000 Gerrit-HasComments: Yes
