Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16495 )
Change subject: KUDU-2612 p2 (b): add transaction status retrieval ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/16495/3/src/kudu/transactions/txn_status_manager-test.cc File src/kudu/transactions/txn_status_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/16495/3/src/kudu/transactions/txn_status_manager-test.cc@405 PS3, Line 405: // Make the TxnManager start from scratch. > nit: TxnStatusManager Done http://gerrit.cloudera.org:8080/#/c/16495/3/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/16495/3/src/kudu/tserver/tablet_service.cc@1278 PS3, Line 1278: } else if (op.type() == CoordinatorOpPB::GET_TXN_STATUS) { > Could you also add some test coverage for this, maybe in TxnStatusTabletMan Done -- To view, visit http://gerrit.cloudera.org:8080/16495 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45f099d943f2b7955d6d561a1cb883343c7b79a4 Gerrit-Change-Number: 16495 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 28 Sep 2020 19:03:31 +0000 Gerrit-HasComments: Yes
