Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16520 )
Change subject: [thirdparty] Fix LLVM build on macOS with Xcode 12 ...................................................................... [thirdparty] Fix LLVM build on macOS with Xcode 12 After upgrading Xcode I started seeing failures when building thirdparty. An example is below. It looks like the issue stems from a change in the default architecture to include arm64. Full details on the issue can be seen here: https://gitlab.kitware.com/cmake/cmake/-/issues/20893 To work around this issue this patch sets `-DCMAKE_OSX_ARCHITECTURES="x86_64”` in the LLVM build. Example failure log: ld: warning: building for iOS, but linking in .tbd file (/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.0.sdk/usr/lib/system/libsystem_coreservices.tbd) built for iOS Simulator … fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: /Users/ghenke/Source/kudu/thirdparty/build/llvm-9.0.0/lib/libclang_rt.builtins_arm64_ios.a and /Users/ghenke/Source/kudu/thirdparty/build/llvm-9.0.0/lib/libclang_rt.builtins_arm64_iossim.a have the same architectures (arm64) and can't be in the same fat output file Change-Id: I0e7808fcd92227cd83b35f5bf1b9320c7887b603 Reviewed-on: http://gerrit.cloudera.org:8080/16520 Reviewed-by: Alexey Serbin <aser...@cloudera.com> Tested-by: Kudu Jenkins --- M thirdparty/build-definitions.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/16520 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0e7808fcd92227cd83b35f5bf1b9320c7887b603 Gerrit-Change-Number: 16520 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120)
