Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16526 )
Change subject: KUDU-2612 p5 (b): add highest_seen_txn_id into CoordinatorOpResultPB ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/16526/3/src/kudu/tablet/txn_coordinator.h File src/kudu/tablet/txn_coordinator.h: http://gerrit.cloudera.org:8080/#/c/16526/3/src/kudu/tablet/txn_coordinator.h@58 PS3, Line 58: // TODO(aserbin): document the 'highest_seen_txn_id' parameter Can this be done in this patch, or is there additional functionality you're waiting on? http://gerrit.cloudera.org:8080/#/c/16526/3/src/kudu/transactions/txn_status_manager.cc File src/kudu/transactions/txn_status_manager.cc: http://gerrit.cloudera.org:8080/#/c/16526/3/src/kudu/transactions/txn_status_manager.cc@164 PS3, Line 164: // Always set the 'highest_seen_txn_id' on return. : SCOPED_CLEANUP({ : if (highest_seen_txn_id) { : std::lock_guard<simple_spinlock> l(lock_); : *highest_seen_txn_id = highest_txn_id_; : } : }); Actually, rather than dropping and re-taking locks via this SCOPED_CLEANUP, how would you feel about just explicitly putting these in the below lock_ block. We then would also not set this if the tablet isn't loaded. -- To view, visit http://gerrit.cloudera.org:8080/16526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcb4d90bc10a5695c3f54229688ccdcaf56011d0 Gerrit-Change-Number: 16526 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 02 Oct 2020 18:05:38 +0000 Gerrit-HasComments: Yes
