Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16598 )
Change subject: [java] add method to deserialize scanner token into scanner builder ...................................................................... Patch Set 5: Thanks for the patch! I know the change/functionality is trivial, but do you mind adding a test that deserializes into a scan token builder, adds a dynamic filter, and uses the token? That way we ensure we don't break the use case in the future. -- To view, visit http://gerrit.cloudera.org:8080/16598 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17b24a8e9dec846583ad0940de19b96b672bd603 Gerrit-Change-Number: 16598 Gerrit-PatchSet: 5 Gerrit-Owner: Li Zhiming <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 14 Oct 2020 16:01:26 +0000 Gerrit-HasComments: No
