Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15661 )
Change subject: python: support for passing arrow data to python ...................................................................... Patch Set 3: (2 comments) Had some time this weekend so I rebased this and added some tests. http://gerrit.cloudera.org:8080/#/c/15661/2/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/15661/2/src/kudu/client/schema.cc@928 PS2, Line 928: // Returns a c-string for the column type, using 'arena' to store > It could be worth linking to the documentation on this: Done http://gerrit.cloudera.org:8080/#/c/15661/2/src/kudu/client/schema.cc@941 PS2, Line 941: case FLOAT: return "f"; > I think we can support DATE with `tdD `: Done Noteworthy that Arrow doesn't support DECIMAL32 and DECIMAL64. Might be worth allowing coercion to more granular decimals (i.e. from 32 to 64, 64 to 128, etc). -- To view, visit http://gerrit.cloudera.org:8080/15661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5df4714bf5ac339d675f2a9169f8aeff06d30eed Gerrit-Change-Number: 15661 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wes McKinney <[email protected]> Gerrit-Comment-Date: Sun, 18 Oct 2020 03:54:21 +0000 Gerrit-HasComments: Yes
