Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16604 )
Change subject: [docs] Automatically generate a metrics reference page ...................................................................... Patch Set 1: (2 comments) Thank you for adding this. Looks good to me, just a couple of nits. http://gerrit.cloudera.org:8080/#/c/16604/1/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/16604/1/src/kudu/util/metrics.h@923 PS1, Line 923: private style nit: add a space before the 'private' label http://gerrit.cloudera.org:8080/#/c/16604/1/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/16604/1/src/kudu/util/metrics.cc@620 PS1, Line 620: std::ostringstream s; Why to use std::ostringstream here at all? Could every element be output right into std::cout right away? -- To view, visit http://gerrit.cloudera.org:8080/16604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I052a043a10a258fd52ff6cc7779e37becb0a3a35 Gerrit-Change-Number: 16604 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 19 Oct 2020 15:42:16 +0000 Gerrit-HasComments: Yes
