Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16580 )
Change subject: KUDU-3149: don't block op registration on MM mutex ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/16580/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16580/8//COMMIT_MSG@22 PS8, Line 22: the following results > Looks like a good improvement, indeed! This was a release build. http://gerrit.cloudera.org:8080/#/c/16580/8/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/16580/8/src/kudu/tserver/tablet_server-test.cc@4407 PS8, Line 4407: LOG_TIMING(INFO, "waiting for all bootstraps to finish") { : ASSERT_OK(mini_server_->server()->tablet_manager()->WaitForAllBootstrapsToFinish()); > Do you think it's worth adding this new test into the set of micro-benchmar Sure I'll put up a patch for that. http://gerrit.cloudera.org:8080/#/c/16580/8/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/16580/8/src/kudu/util/maintenance_manager.cc@283 PS8, Line 283: CHECK_GT(num_erased_ops, 0); > Ah, I take this back: it seems the original code asserted on the premise th It's fine if UnregisterOp() is called concurrently -- removal from ops_ and ops_pending_registration_ is guarded by lock_ and registration_lock_. -- To view, visit http://gerrit.cloudera.org:8080/16580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a1b810f5b7ff6a22acc9b10b79ddffa8085c990 Gerrit-Change-Number: 16580 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 19 Oct 2020 22:23:08 +0000 Gerrit-HasComments: Yes
