Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16657 )
Change subject: Add option to enforce FIPS approved mode ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/16657/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16657/4//COMMIT_MSG@11 PS4, Line 11: This needs to be an environment variable : instead of a flag so that this check can be used in the C++ client as : well. nit: can you add this as a comment around where the environment variable gets checked? http://gerrit.cloudera.org:8080/#/c/16657/4/src/kudu/security/openssl_util.cc File src/kudu/security/openssl_util.cc: http://gerrit.cloudera.org:8080/#/c/16657/4/src/kudu/security/openssl_util.cc@130 PS4, Line 130: "KUDU_REQUIRE_FIPS_MODE" Do we need to check what its value is? http://gerrit.cloudera.org:8080/#/c/16657/4/src/kudu/security/openssl_util.cc@131 PS4, Line 131: : nit: drop the ":"? http://gerrit.cloudera.org:8080/#/c/16657/4/src/kudu/security/openssl_util.cc@131 PS4, Line 131: require nit: required http://gerrit.cloudera.org:8080/#/c/16657/4/src/kudu/security/openssl_util.cc@132 PS4, Line 132: nit: spacing -- To view, visit http://gerrit.cloudera.org:8080/16657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98a6a8b3330ea0b372b188690fadd4d312d8bf93 Gerrit-Change-Number: 16657 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 27 Oct 2020 18:53:34 +0000 Gerrit-HasComments: Yes
