Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16667 )
Change subject: [python] KUDU-1563. Add support for UPDATE_IGNORE and DELETE_IGNORE ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/16667/3/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: http://gerrit.cloudera.org:8080/#/c/16667/3/python/kudu/tests/test_client.py@221 PS3, Line 221: {'key': -998}) nit: can we also add an instantiation of new_delete_ignore() that supplies a tuple? Or is that not supported? It's a bit less obvious since deletes don't need to specify entire rows, and having a test would help serve as an example. -- To view, visit http://gerrit.cloudera.org:8080/16667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad0fbd1db1edc140b88e1559ecf5d89bf6d9cbb9 Gerrit-Change-Number: 16667 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 28 Oct 2020 05:23:35 +0000 Gerrit-HasComments: Yes
