Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16657 )
Change subject: Add option to enforce FIPS approved mode ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/16657/4/src/kudu/security/openssl_util.cc File src/kudu/security/openssl_util.cc: http://gerrit.cloudera.org:8080/#/c/16657/4/src/kudu/security/openssl_util.cc@130 PS4, Line 130: ERR_clear_error(); : return Status::RuntimeError( : "SSL library appears uninitialized (cannot create SSL_CTX)"); > As another thought: if we have such a trouble determining whether KUDU_REQU Good point, refactored it and added the check to CheckOpenSSLInitialized() too. http://gerrit.cloudera.org:8080/#/c/16657/6/src/kudu/security/openssl_util.cc File src/kudu/security/openssl_util.cc: http://gerrit.cloudera.org:8080/#/c/16657/6/src/kudu/security/openssl_util.cc@196 PS6, Line 196: // LSAN warnings. : debug::ScopedLeakCheckDisabler d; > We have GetBooleanEnvironmentVariable() in test_util.cc to handle this. Yea I just found it, should I move it to some other util? -- To view, visit http://gerrit.cloudera.org:8080/16657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98a6a8b3330ea0b372b188690fadd4d312d8bf93 Gerrit-Change-Number: 16657 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 29 Oct 2020 07:40:49 +0000 Gerrit-HasComments: Yes
