Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16683 )
Change subject: KUDU-1563 Use DELETE_IGNORE in KuduRestore job ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/16683/3/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala: http://gerrit.cloudera.org:8080/#/c/16683/3/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@594 PS3, Line 594: @KuduTestHarness.MasterServerConfig(flags = Array("--master_support_ignore_operations=false")) nit: similar feedback to the previous patch -- might be nice to add a hint for future readers that this test is intentionally identical to the below test. -- To view, visit http://gerrit.cloudera.org:8080/16683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22 Gerrit-Change-Number: 16683 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 06 Nov 2020 07:56:11 +0000 Gerrit-HasComments: Yes
