Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16715 )
Change subject: [docs] Update doxygen requirements in docs ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/16715/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16715/1//COMMIT_MSG@12 PS1, Line 12: which is not enough now. > Because older versions are available in the Ubuntu, CentOS, RHEL repositori Ah, I see. Thank you for the clarification. I forgot those older releases have older version of the stock doxygen package. Maybe, it seems self-evident, but I think it would be nice to mention that stock doxygen package is of too old version for this requirement. My first thought was: those were missing graphiz integration or alike :) http://gerrit.cloudera.org:8080/#/c/16715/1/docs/installation.adoc File docs/installation.adoc: http://gerrit.cloudera.org:8080/#/c/16715/1/docs/installation.adoc@135 PS1, Line 135: graphviz nit: I guess libgraphviz-dev would be required in addition if building doxygen from its source? Not sure it should be in this line, though -- maybe just mention that in the newly added NOTE below? http://gerrit.cloudera.org:8080/#/c/16715/1/docs/installation.adoc@140 PS1, Line 140: built from source Is graphviz support is required by doxygen config by default when building manually? Would be nice to mention graphviz support is needed to be in the list of features for the result binary. http://gerrit.cloudera.org:8080/#/c/16715/1/docs/installation.adoc@142 PS1, Line 142: CentOS older than 8.0 It seems CentOS 8 has doxygen-1.8.14: https://centos.pkgs.org/8/centos-powertools-x86_64/doxygen-1.8.14-12.el8.x86_64.rpm.html -- To view, visit http://gerrit.cloudera.org:8080/16715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0f92f185490ad15d8f4f71d9c7fc5f6a6073fdc Gerrit-Change-Number: 16715 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 12 Nov 2020 19:39:10 +0000 Gerrit-HasComments: Yes
