Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16515 )
Change subject: KUDU-2612: add txn memrowsets to tablet ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/16515/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16515/3//COMMIT_MSG@13 PS3, Line 13: be scanned by any scanner > Does it mean that those would not be scanned even if using READ_YOUR_WRITES That's right. RYW in the context of scanners is feasible, but I don't think it should be the default -- I think users should opt into scanning uncommitted data by providing a transaction ID when scanning. http://gerrit.cloudera.org:8080/#/c/16515/3//COMMIT_MSG@36 PS3, Line 36: when the transactional MRS is flushed to disk > I'm curious what happens if a kudu-tserver process crashes after flushing c The flag is persisted at the time of flush, so if the flag didn't make it into the metadata, neither did that DRS, so we'd be left with an MRS. -- To view, visit http://gerrit.cloudera.org:8080/16515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dea4031c0acb875993352d452dc4c233e35a502 Gerrit-Change-Number: 16515 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 13 Nov 2020 08:35:17 +0000 Gerrit-HasComments: Yes
